Skip to content

Unused Private param in documentation #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

matt9mg
Copy link
Contributor

@matt9mg matt9mg commented Oct 23, 2017

Removed a private param from the documentation as its not used in the code example

Removed a private param from the documentation as its not used in the code example
@xabbuh
Copy link
Member

xabbuh commented Oct 24, 2017

Actually, inside uploadFile() the $fileName variable may not be defined when we use it. Can you fix that too? :)

@xabbuh xabbuh added this to the 2.7 milestone Oct 24, 2017
@matt9mg
Copy link
Contributor Author

matt9mg commented Oct 24, 2017

@xabbuh #8541

@xabbuh
Copy link
Member

xabbuh commented Oct 27, 2017

Thank you @matt9mg.

xabbuh added a commit that referenced this pull request Oct 27, 2017
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #8540).

Discussion
----------

Unused Private param in documentation

Removed a private param from the documentation as its not used in the code example

Commits
-------

3daf824 Unused Private param in documentation
@xabbuh xabbuh closed this Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants